Enable voice-only Aiden Live by default in 0.41.5 - #137
Merged
Merged
Conversation
There was a problem hiding this comment.
Important
The default-on rollout is sound, but the emergency override does not fully fail closed for an explicitly empty value.
Reviewed changes This review covers the default Live capability gate, the separate screen-capture gate, release metadata, and the focused test updates.
- Voice-only capability gate —
geminiLiveEnablednow enables Live when unset, preserves the0/falsekill switch, and rejects other non-empty values. - Screen and action boundaries — screen sharing still requires
AIDEN_EXPERIMENTAL_GEMINI_LIVE_SCREEN=1, while Computer Use retains its independent persisted enablement, readiness, and authorization checks. - Release metadata and coverage — the package version and Live plan are updated, and the focused Live and Computer Use suites cover the new default behavior.
ℹ️ Nitpicks
tests/e2e/fixtures.ts:755-756still says the production candidate is acceptance-gated. The explicitAIDEN_EXPERIMENTAL_GEMINI_LIVE=1remains harmless, but the comment should explain its current test purpose now that the production default is enabled.
GPT Luna | 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Re-reviewed the changes since the prior Pullfrog review and the full PR context.
- Separated absent and explicit values — Updated
geminiLiveEnabledto default on only for an undefined flag while rejecting explicit empty, whitespace-only, and unknown overrides. - Added fail-closed regressions — Added exact assertions for empty and whitespace-only overrides while retaining the kill switch and screen-gate coverage.
GPT Luna | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Verification