Skip to content

Stabilize draft migration E2E relaunch seeding - #138

Merged
sambitcreate merged 1 commit into
mainfrom
feature/stabilize-draft-migration-e2e
Sep 17, 2026
Merged

sambitcreate merged 1 commit into
mainfrom
feature/stabilize-draft-migration-e2e

Conversation

@sambitcreate

Copy link
Copy Markdown
Owner

Summary

  • add a post-shutdown/pre-launch hook to the Electron E2E relaunch helper
  • seed migration fixtures only after Electron has fully closed
  • cover all draft-migration tests that previously edited persisted files while the app was running

Why

Main CI for the 0.41.5 release twice classified the draft migration test as flaky because Electron shutdown could flush an older in-memory chat index over the test fixture. This is test-harness-only; the signed/notarized 0.41.5 release workflow passed and production code is unchanged.

Verification

  • npm run type-check:e2e
  • npm run build
  • focused draft-chat E2E with --repeat-each=3 --fail-on-flaky-tests (15 passed)
  • npm run type-check
  • npm run lint
  • git diff --check

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — Reviewed the post-shutdown relaunch hook, migration fixture updates, and troubleshooting note.

  • Relaunch lifecycle — The fixture closes the prior Electron process before running the optional async callback and launches the replacement only after all callback writes complete.
  • Migration coverage — The draft-chat scenarios now seed persisted chats, journals, receipts, and markers only between relaunches, preventing shutdown persistence from overwriting the fixtures.
  • Troubleshooting record — The papercut entry documents the shutdown-seeding failure mode for future E2E work.

Pullfrog  | View workflow run | Using GPT Luna𝕏

@sambitcreate
sambitcreate merged commit 732998d into main Sep 17, 2026
5 checks passed
@sambitcreate
sambitcreate deleted the feature/stabilize-draft-migration-e2e branch September 17, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant