Stabilize draft migration E2E relaunch seeding - #138
Merged
Merged
Conversation
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — Reviewed the post-shutdown relaunch hook, migration fixture updates, and troubleshooting note.
- Relaunch lifecycle — The fixture closes the prior Electron process before running the optional async callback and launches the replacement only after all callback writes complete.
- Migration coverage — The draft-chat scenarios now seed persisted chats, journals, receipts, and markers only between relaunches, preventing shutdown persistence from overwriting the fixtures.
- Troubleshooting record — The papercut entry documents the shutdown-seeding failure mode for future E2E work.
GPT Luna | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Why
Main CI for the 0.41.5 release twice classified the draft migration test as flaky because Electron shutdown could flush an older in-memory chat index over the test fixture. This is test-harness-only; the signed/notarized 0.41.5 release workflow passed and production code is unchanged.
Verification
npm run type-check:e2enpm run build--repeat-each=3 --fail-on-flaky-tests(15 passed)npm run type-checknpm run lintgit diff --check