Repository navigation
[Fix] Correct stale file headers and Argus Health wording, add a header check (#58) - #83
Merged
Merged
Conversation
…ader on the first line, test the checker (#58)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #58
Changes
Header comment lines only in the 114 existing
.csfiles; no code changed.ArgusRequestSerializer.cs(wasArgusTextRequestSerializer.cs),ArgusResponseSerializer.cs(wasArgusTextResponseSerializer.cs), and two more that the issue did not list:ArgusRequest.cs(wasHealthServiceMessage.cs) andArgusVerb.cs(wasHealthServiceMessageCommandType.cs).Copyright (c) 2025-2026 Sam Gerenéeverywhere. FixedGerenéwithout first name (ArgusRequestSerializer.cs),Sam Gerenewithout accent (two test fixtures) and(C)(ArgusClient.cs,IArgusClient.cs).<copyright file="X" >: the space before>is removed in five files.ArgusTransfer.sln.DotSettings: the file header template had the same three defects (" >,(C) 2026,softwareUseCases) and would have reintroduced them in new files.README.mdno longer contains it (fixed earlier), but the issue and pull-request templates in.githubstill did. The pull-request template's link toCONTRIBUTING.mdpointed at amasterbranch that does not exist; it now points atdevelopment.LicenseHeaderTestFixtureverifies for every source file in the solution that the header names the file itself, has the copyright line and contains the license lines, and that the header starts on the first line. It scans the three project directories only, so a scratch project or worktree inside the checkout does not fail it. The checker has its own tests for each kind of deviation. It found the two(C)files above.CLAUDE.md: the license header convention names the expected lines and the test.Issue check
ArgusRequestSerializer.cs: wrong file name and "Gerené" without first nameArgusResponseSerializer.cs: wrong file nameREADME.mdrefers to "the Argus Health application"development; the same wording in the two.githubtemplates is fixed hereLicenseHeaderTestFixtureVerification
dotnet build ArgusTransfer.sln: 0 warningsdotnet test ArgusTransfer.sln: 668 passeddotnet format ArgusTransfer.sln --verify-no-changes: cleandotnet build ArgusTransfer.sln -warnaserror: succeeded🤖 Generated with Claude Code