Skip to content

[Fix] Correct stale file headers and Argus Health wording, add a header check (#58) - #83

Merged
samgerene merged 2 commits into
developmentfrom
feature/58-file-headers
Oct 11, 2026
Merged

samgerene merged 2 commits into
developmentfrom
feature/58-file-headers

Conversation

@samgerene

@samgerene samgerene commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

Closes #58

Changes

Header comment lines only in the 114 existing .cs files; no code changed.

  • File names in headers: ArgusRequestSerializer.cs (was ArgusTextRequestSerializer.cs), ArgusResponseSerializer.cs (was ArgusTextResponseSerializer.cs), and two more that the issue did not list: ArgusRequest.cs (was HealthServiceMessage.cs) and ArgusVerb.cs (was HealthServiceMessageCommandType.cs).
  • Copyright line: now Copyright (c) 2025-2026 Sam Gerené everywhere. Fixed Gerené without first name (ArgusRequestSerializer.cs), Sam Gerene without accent (two test fixtures) and (C) (ArgusClient.cs, IArgusClient.cs).
  • <copyright file="X" >: the space before > is removed in five files.
  • License text: every file said "agreed to in writing, softwareUseCases" where the Apache-2.0 text says "software". Corrected in all 114 files; this is why the diff touches every file.
  • ArgusTransfer.sln.DotSettings: the file header template had the same three defects (" >, (C) 2026, softwareUseCases) and would have reintroduced them in new files.
  • "Argus Health" wording: README.md no longer contains it (fixed earlier), but the issue and pull-request templates in .github still did. The pull-request template's link to CONTRIBUTING.md pointed at a master branch that does not exist; it now points at development.
  • Header check (the optional part of the issue): LicenseHeaderTestFixture verifies for every source file in the solution that the header names the file itself, has the copyright line and contains the license lines, and that the header starts on the first line. It scans the three project directories only, so a scratch project or worktree inside the checkout does not fail it. The checker has its own tests for each kind of deviation. It found the two (C) files above.
  • CLAUDE.md: the license header convention names the expected lines and the test.

Issue check

Point in #58 Status
ArgusRequestSerializer.cs: wrong file name and "Gerené" without first name Fixed
ArgusResponseSerializer.cs: wrong file name Fixed
README.md refers to "the Argus Health application" Already fixed on development; the same wording in the two .github templates is fixed here
Inconsistent license headers Fixed for all files, including variants the issue did not list
Optional: a check for header consistency Added as LicenseHeaderTestFixture

Verification

  • dotnet build ArgusTransfer.sln: 0 warnings
  • dotnet test ArgusTransfer.sln: 668 passed
  • dotnet format ArgusTransfer.sln --verify-no-changes: clean
  • dotnet build ArgusTransfer.sln -warnaserror: succeeded

🤖 Generated with Claude Code

@sonarqubecloud

Copy link
Copy Markdown

@samgerene
samgerene merged commit 81ca241 into development Oct 11, 2026
3 checks passed
@samgerene
samgerene deleted the feature/58-file-headers branch October 11, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Fix stale file headers and README wording

1 participant