Repository navigation
Conversation
Co-authored-by: yumisims <13556579+yumisims@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job build on Windows
Fix Windows ARM64 build failure from x86-only memory fence
Sep 18, 2026
yumisims
approved these changes
Sep 18, 2026
yumisims
marked this pull request as ready for review
September 18, 2026 20:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build (windows-11-arm, arm64, windows-arm64, windows)job failed because the Windows build path used an x86-only fence intrinsic in shared code. On ARM64 runners, MSVC could not resolve_mm_mfence, stopping compilation ofPretextView.cpp.Root cause
ThreadFenceininclude/Header.hmapped to_mm_mfence()for all Windows targets.Change
ThreadFencedefinition withMemoryBarrier().Impact
Relevant snippet