Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary change type
Problem and motivation
End could dismiss a Studio session while one managed engine was still running. A cleanup deadline or failed metadata write must not be reported as successful termination.
Summary and scope
Coordinate Terminal and Assistant End under one per-session operation. Fence admission and request both shutdowns before waiting for metadata. Persist ended only after confirmed cleanup, and return a bounded 409 result for unresolved process or storage outcomes. Completed retries check both engines again, including a Terminal restarted under an ended Assistant header. Map expected Terminal resume conflicts to 409. Zero-revision defaults do not claim an active Assistant in the public projection.
Related work
Related issue: https://linear.app/sapiom/issue/SAP-3292
Depends on #1001. Native stack target: main. Existing confirmation/history UI follows in the dependent increment.
Validation
Tests and documentation
Tests cover concurrent End, startup cancellation, same-ID Terminal restart, bounded and failed storage, late reads after timeout, cleanup uncertainty, and REST conflicts. Documented the result contract and prior-host uncertainty. pr:size is absent; measured increment: 661 changed lines including tests and changeset.
Compatibility and release impact
Security
AI assistance
Checklist