Skip to content

feat(harness): verify one paused native continuation seed [SAP-3292] - #1012

Closed
ynadge wants to merge 1 commit into
assistant-continuation-admissionfrom
assistant-continuation-native
Closed

ynadge wants to merge 1 commit into
assistant-continuation-admissionfrom
assistant-continuation-native

Conversation

@ynadge

@ynadge ynadge commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Primary change type

  • Feature

Problem and motivation

Native session/message IDs do not make writes idempotent: repeating an uncertain Continue operation can duplicate a conversation or overwrite a seed. Prepared context must not start model work.

Summary and scope

Persist creation/seeding intent before native writes, reconcile exact operation markers and one native conversation, and verify one synchronous synthetic no-reply seed through direct and history reads. Validate the exact accepted system, child scope, receipt attempt and brief hash. Reject ambiguous outcomes and fence hung/late requests across End; never blindly resend.

Related work

Related issue: https://linear.app/sapiom/issue/SAP-3292

Depends on #1011. Native stack target: main. Full allocator/lifecycle/HTTP/UI composition follows.

Validation

Native helper, receipt, delivery and source-store suites — 90 passed, including 17 native-helper tests
Full Harness TypeScript, build:server, scoped ESLint --max-warnings 0, Prettier — passed
Pre-mutation authority cancellation guard mutation — failed as expected, restored
Actual built helper + corrected owned native candidate — lost create/seed ACKs reconciled across two restarts; one conversation, one seed, zero model calls until explicit input
First explicit child message — valid new accepted context with retained brief; controlled read completed in two loopback model requests
Committed material loss — acceptFrozen/compose rejected without repairing material or native/model mutation

Tests and documentation

Exact candidate: OpenCode 1.18.29-sapiom.3328.2, Linux x64 SHA256 073b7b0864b7f5bb30ef9e8e79dc5267ef347c08cd16800ed51563e1e55b1277, matching plugin 1.18.29. Probe loaded actual built helpers and real receipt/source stores, with disposable state and a loopback provider. This establishes E2 candidate behavior; production pin/activation and signed installed E3 acceptance remain external gates. Updated assistant-continuation.md. Increment:896 changed lines including tests/docs/changeset; pr:size is absent.

Compatibility and release impact

  • Breaking or externally visible changes: trusted internal native preparation only; no generic browser prompt path added.
  • Changeset: added for @sapiom/harness.
  • Fix-forward: retain receipts and uncertain phases while correcting exact native reconciliation. Never resubmit uncertain creation or seed writes.

Security

  • No secrets, credentials, private data, or unsanitized logs included.
  • No suspected vulnerability disclosed publicly.

AI assistance

  • AI assistance used: Codex implemented/reviewed the native helper and tested the actual built helper against the corrected candidate; root reviewed cancellation, accepted-context identity and native evidence.

Checklist

  • CONTRIBUTING.md read; maintainer-authorized issue work.
  • One focused increment, tests, relevant checks, documentation, and release impact addressed above.
  • I can explain and maintain the submitted changes.

Devin Review

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 57373b91-3b41-4134-8ee6-2275853678ef

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant