Repository navigation
feat(browser-pay): pay Adyen secured-fields checkouts SAP-5180 #1316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ratataque
wants to merge
6
commits into
main
Choose a base branch
from
ewan/sap-5180-browser-pay-adyen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,388
−56
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
961e27c
feat(browser-pay): pay Adyen secured-fields checkouts via BT re-encry…
ratataque 4f5cbfd
fix(browser-pay): read Adyen not-enabled in any case, type a per-bran…
ratataque cfdd6e0
test(browser-pay): give the Adyen interceptor integration test the 60…
ratataque b005974
fix(browser-pay): read the page's Adyen client key only when every DO…
ratataque e2ca340
fix(browser-pay): type the Adyen stand-in only into a number field Ad…
ratataque 4a01e17
fix(browser-pay): let an Adyen not-enabled answer void every prepared…
ratataque File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@sapiom/browser-pay": minor | ||
| --- | ||
|
|
||
| Pay Adyen secured-fields checkouts by re-encrypting the card in the card vault (SAP-5180). The interceptor holds an outgoing Adyen payment (`paymentMethod.encryptedCardNumber`, on the merchant's `/payments` call or Adyen's `/sessions/{id}/payments`), asks `POST /v1/transactions/{id}/payment/adyen/encrypt` for the card's own encrypted fields, swaps the four `encrypted*` fields and sends the request on. It runs only when the backend answers with fields: its `adyen_encryption_not_enabled` answer, a relay without `adyenEncrypt`, or `disableAdyenEncryption: true` fail the payment closed (`adyen_not_enabled`). `fillCard(page, card, { adyen: handle })` asks first and types nothing on Adyen secured fields unless the payment will be re-encrypted (`blocked`). There it types Adyen's plain test card for the card's `brand` (`visa`, `mastercard`, `american-express`) instead of the placeholder number, so Adyen's variant check fits the real card; another or no brand is `blocked: "adyen_card_brand"`. The backend's not-enabled code is read in any case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.