Repository navigation
Take the SAT logo and the OS colour scheme from qmlcomponents - #29
Merged
Merged
Conversation
Theme.dark now follows Application.styleHints.colorScheme on its own, so the Binding here was doing the shared module's job. The SAT logo likewise comes from Theme.satLogoSource, which picks the black or white lockup for the active scheme; the bundled sat_logo.png was the white one only and showed up near-invisible on a light desktop. The submodule points at the head of qmlcomponents' sat-logo-os-colour-scheme branch, which is NOT merged yet (sat-mtl/qmlcomponents#6). Re-point it at the merge commit before this lands. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019QYyvhRXvSMSRQPaq12Teq
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019QYyvhRXvSMSRQPaq12Teq
The pin was the head of the then-unmerged PR #6. Same tree, but actions/checkout with submodules: recursive does not fetch refs/pull/*, so CI could not resolve it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019QYyvhRXvSMSRQPaq12Teq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on sat-mtl/qmlcomponents#6.
qml/Main.qml: drops theBinding { target: Theme; property: "dark" }—Theme.darknow followsApplication.styleHints.colorSchemeinside the shared module.qml/Main.qml:315: the SAT partner logo isTheme.satLogoSourceinstead of a bundled PNG. The bundledqml/spm/resources/images/sat_logo.pngwas the white lockup only, so on a light desktop it rendered near-invisible; it is deleted.Submodule
qml/ca/qc/sat/qmlcomponentsis bumped73faf69→a4348c9, which is the head of the unmergedsat-logo-os-colour-schemebranch. Re-point it at the merge commit before this lands.Validation
Ran the shipped
packages-master-2026-10-09AppImage — i.e. a real-DSCORE_QT_PLUGINS_NO_IMAGEFORMATS=1 -DSCORE_QT_PLUGINS_NO_QTQUICK3D=1static build — with its bundledqml/tree swapped for this branch's, on a live Plasma 6 / Wayland session, and flipped the OS colour scheme underneath it withplasma-apply-colorscheme.One process, no restart:
colorSchemeTheme.darkTheme.satLogoSourcelogo-sat-white.pnglogo-sat-black.pnglogo-sat-white.pngScreenshots of the About dialog in each scheme show the black lockup on the light background and the white one on the dark background, both decoding correctly.
🤖 Generated with Claude Code
https://claude.ai/code/session_019QYyvhRXvSMSRQPaq12Teq