Repository navigation
Reduce peak GPU memory during histogram tree growth - #31
Merged
dev-rinchin merged 1 commit intoOct 27, 2026
Merged
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deep or wide trees can exhaust GPU memory while constructing cumulative histograms because the raw histogram and its cumulative copy coexist. Previous-level histograms and split-score tensors also remain live after their last use.
Accumulate each histogram in place, release the parent histogram after subtraction, and discard split scores and the full current histogram when they are no longer needed. This preserves the tree-growth algorithm and array dtypes.
Validation:
Tested on RTX 5090 with CuPy 14.2.0 and CUDA runtime 12.9. This is not a V100 hardware benchmark. Large histograms and split-score arrays can still exhaust VRAM at high depth.