feat(repl): support the repository directive and :repository command - #26901
Merged
warcholjakub merged 2 commits intoAug 24, 2026
Merged
Conversation
SolalPirelli
approved these changes
Aug 24, 2026
SolalPirelli
left a comment
SolalPirelli
left a comment
Contributor
There was a problem hiding this comment.
looks good overall but worth a [test_windows_full] in the PR description to make sure we're not depending on Linux-only behavior for the test imho
|
|
||
| @Test def `repository parses aliases, URLs, ivy patterns and local directories`: Unit = | ||
| List("central", "ivy2Local", "ivy2local", "m2Local", "m2local", "https://jitpack.io", | ||
| "file:///tmp/repo", "ivy:file:///tmp/repo/[defaultPattern]", |
Contributor
There was a problem hiding this comment.
isn't this going to fail on any OS for which the temp directory is not /tmp?
Member
Author
There was a problem hiding this comment.
Hmm, yeah, that's fair. Haven't thought of that 🤔
Member
Author
There was a problem hiding this comment.
Windows tests passed
SolalPirelli
enabled auto-merge (squash)
August 24, 2026 13:59
warcholjakub
disabled auto-merge
August 24, 2026 14:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26750
As in the title. One minor note - it adds a limited support for aliases, because in
coursier-interfacethere's no access to repository parser (hence, the TODO comment). When it'll become available (coursier/interface#478 - I hope soon), then I'll change that.[test_windows_full]
Have you relied on LLM-based tools in this contribution?
Yes, and I checked the output by testing manually with bin/replQ
How was the solution tested?
New automated tests (including the issue's reproducer, if applicable)