Repository navigation
test(prompt_agent): pin down a multi-turn conversation's user side as it runs today - #331
Merged
sarah-chitty-1 merged 2 commits intoOct 26, 2026
Conversation
… it runs today Each test records every request a conversation makes, in order, and what it stores, for each way a turn can end: the LLM user sim's reply, done, malformed output, extra fields, timeout, a task that doesn't complete and empty parts; agent triggers fired, done and none; a human peer; and external close, agent failure and the turn limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…so a change to it fails the test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
earakely-scale
approved these changes
Oct 26, 2026
sarah-chitty-1
deleted the
sarahchitty/prompt-agent-user-side-characterization
branch
October 26, 2026 22:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A characterization test of prompt_agent's user side, so the rework in #265 can show it leaves that side unchanged. Each test records every request a conversation makes, in order, and what it stores. The requests cover the agent, the user sim or a human peer, agent-trigger
decide, env trigger state, and the firing-log readback. The records cover the stored conversation and theenv_trigger_snapshots,agent_trigger_firings,usersim_turn_outputsandagent_trigger_statemetadata.The cases:
done(its message stays unrecorded), malformed JSON, a reply missingdone, extra fields, a timeout (its task is cancelled), a task that fails, is canceled or is rejected, and a reply with no parts.user_a2a_url, and the configured default.Worth a look
MockTransportand the conversation goes to the real local store, so the test pins requests and stored records, not function calls. A refactor that keeps the behaviour passes it unchanged. Ids are normalized: the conversation's is<ctx>, and the others are<idN>in order of appearance.Tests
tst/unit,packages/agentenv-protocol/tests): 10442 passed, 2 failed. Both failures are intest_mcp_cli_builder.py, whose generated scripts run this machine's systempython3, which has noclick. They're unrelated to this change.ruff check: clean.uv lock --check: ok.🤖 Generated with Claude Code


Confidence Score: 5/5
This test-only PR appears safe to merge.Summary
Adds tests that pin down requests and stored records for
prompt_agentconversations.Reviews (2) · Last reviewed commit: "review: the user-side test pins the user..." · Reviewed by Greptile