Repository navigation
feat(website): a Notes site on WebsiteEnvironment, one image that passes the conformance check (FD-4683) - #429
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
d76be33 to
a68ff2a
Compare
3579c2a to
76145d2
Compare
a68ff2a to
f1a665a
Compare
30113cb to
d43c767
Compare
05da818 to
33ad3b8
Compare
…ses the conformance check (FD-4683) This PR's change, rebased as one commit onto #428. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…s, and adds a note once per submit (FD-4683) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…sign-in fails, and reloads itself at its slash-ending address (FD-4683) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…hrough data/get, not /go (FD-4683) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…s, settles a save the server accepted, and reloads itself on its own origin (FD-4683) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
d43c767 to
b055f91
Compare
|
@greptile-apps the three findings from the last review are fixed in b055f91:
Each fix was checked in a browser against a built Notes site: with a failing PATCH, against |
|
Confirmed: the changes in b055f918 address all three findings. Failed edits remain in |
Stacked on #428.
packages/agentenv-protocol/examples/website/notes/: a reference site onWebsiteEnvironment, about 130 lines of Python plus a small Vite page.self.now(), auto sign-in as the acting user, and/api/admin/noteswithroles=["admin"](403 otherwise)./website/notes/route. A refresh keeps text typed into a note that isn't saved yet, with its focus and cursor, and the page's clock re-readsX-Universe-Nowevery 5 seconds, so a stopped or faster universe clock shows.PORT, with curl for the compose health check.env.tomldeclares it as the server image.Test
Unit suite and protocol tests: 12,667 passed, lint clean.
test_website_notes_example.py: 8 passed.python -m agentenv_protocol.website.conformance http://localhost:18080 --clock-host host.docker.internalpassed 8/8. Pages, session, notes and the admin route checked by curl.agent-env env website put --server-dockerfile ... --health-path /healthzagainst local stores only.🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge with the noted dependency on PR #443.Summary
Adds a Notes reference site with per-user notes, an admin-only route, a Vite page, and one server image.
Reviews (15) · Last reviewed commit: "fix(website): the Notes page keeps unsav..." · Reviewed by Greptile