Repository navigation
feat(website): one spec declares a site, composes it and checks any server (FD-4683) - #445
Open
williamloo-scale wants to merge 4 commits into
Open
williamloo-scale wants to merge 4 commits into
williamloo-scale wants to merge 4 commits into
Conversation
williamloo-scale
marked this pull request as ready for review
November 3, 2026 00:24
williamloo-scale
force-pushed
the
wloo/website-spec
branch
from
November 3, 2026 21:50
7368619 to
be46573
Compare
williamloo-scale
force-pushed
the
wloo/website-sdk-followups
branch
from
November 3, 2026 21:50
8090f3e to
2d64812
Compare
williamloo-scale
force-pushed
the
wloo/website-spec
branch
from
November 3, 2026 22:52
be46573 to
90499de
Compare
williamloo-scale
force-pushed
the
wloo/website-sdk-followups
branch
from
November 3, 2026 22:52
2d64812 to
0ef31b9
Compare
williamloo-scale
added a commit
that referenced
this pull request
Nov 3, 2026
…v (FD-4683) This PR's change, rebased as one commit onto #445. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
williamloo-scale
force-pushed
the
wloo/website-spec
branch
from
November 3, 2026 23:47
90499de to
c24676d
Compare
williamloo-scale
force-pushed
the
wloo/website-sdk-followups
branch
from
November 3, 2026 23:47
0ef31b9 to
615d6a0
Compare
…erver (FD-4683) This PR's change, rebased as one commit onto #444. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…nds fields, and fails a cookie card for a spec without one (FD-4683) - A spec derived from a WebsiteEnvironment's decorators keeps each @api route's name as @api takes it; an authored spec's route names are still checked. - An extends whose uses or data.collections has the wrong type is a SpecError naming the field, not a TypeError. - The conformance spec check fails a card with a session cookie or path when the spec doesn't sign in by cookie. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ma takes a route's method in either case (FD-4683) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
williamloo-scale
force-pushed
the
wloo/website-spec
branch
from
November 4, 2026 00:32
c24676d to
160c1a1
Compare
…s in lower case and keeps the route names it serves (FD-4683) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #444.
A website spec: one TOML file declares a site, composes from parts, and checks any server against it. Design:
docs/website-spec.md.agentenv_protocol.website.specreads[site],[source],[data],[users],[roles],[routes.ops],[state],[clock],[[uses]]andextends, with validation, overlays, composition, card params,from_card,from_environment, a JSON Schema and a CLI (validate,show,show --card).@website(spec="website.toml"): the class is refused when its@apiroutes aren't the spec's, and its card is built from the spec. Notes now declares itself this way.spec = "website.toml"or an inline[spec]; the env takes its name, health path and domains from it.conformance --specchecks a server's card and routes against the spec; those checks are required.examples/website/specs/: a replayed Slack overlay, an intranet, and an SSO component.Live and replay sources,
served_byandmodels = "mcp:..."are modelled in the spec but not deployable from env.toml yet.Test
Unit suite: 12,793 passed (one GitHub-clone test from main, which hangs on the local machine on main too, deselected).
🤖 Generated with Claude Code


Confidence Score: 5/5
The changes since the previous review appear safe to merge.Summary
Adds a shared website spec for declaring sites, composing components, building cards, and checking running servers.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR TOML[Website TOML] --> Spec[Resolved website spec] Decorators[Existing decorators] --> Spec Card[Server card] --> Spec Spec --> SDK[SDK declaration and card] Spec --> Env[Website env settings] Spec --> Check[Server conformance checks]Reviews (13) · Last reviewed commit: "fix(website): a spec derived from a site..." · Reviewed by Greptile