Skip to content

fix(computer): guard Unix-only pwd import in site_proxy #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
earakely-scale merged 4 commits into from
Nov 9, 2026
Merged

fix(computer): guard Unix-only pwd import in site_proxy #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9f704b
fix(computer): guard Unix-only pwd import in site_proxy
saiyam-jain-dev Nov 6, 2026
1756267
test(computer): add fresh import test for site_proxy without pwd
saiyam-jain-dev Nov 6, 2026
cfc5ff2
fix(computer): revert runtime privilege guards and test fresh site_pr…
saiyam-jain-dev Nov 7, 2026
c099ad5
Merge main; keep only the guard on site_proxy's pwd import
earakely-scale Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/agent_env/env/envs/computer/utils/site_proxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import hashlib
import json
import os
import pwd
import re
import shutil
import socket
Expand All @@ -41,6 +40,11 @@
from typing import Optional
from urllib.parse import urlsplit, urlunsplit

try:
import pwd
except ImportError: # Windows, which agent-env does not target, imports is_local and matches from here on its host.
pwd = None

HOSTS_BEGIN = "# agentenv sites"
HOSTS_END = "# end agentenv sites"
LOOPBACK = "127.0.0.1"
Expand Down
7 changes: 7 additions & 0 deletions tst/unit/env/envs/test_computer_site_proxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import socket
import ssl
import struct
import subprocess
import sys
import urllib.error
from datetime import timedelta
Expand Down Expand Up @@ -984,6 +985,12 @@ def missing(name):
assert (Config.load(str(serve_path)).user, Config.load(str(serve_path)).serve_user) == ("agent", "nobody")


def test_the_proxy_imports_when_pwd_is_unavailable():
subprocess.run([sys.executable, "-c", "import sys; sys.modules['pwd'] = None; "
"from agent_env.env.envs.computer.utils import site_proxy, sites; assert site_proxy.pwd is None"],
check=True)


def test_keep_starts_serve_again_each_time_it_ends(monkeypatch):
runs = []

Expand Down
Loading