Repository navigation
fix(computer): keep app_data.get's original call, pausing the app inside it, so apps exported before 0.9.1457 still boot - #527
Merged
Conversation
…ore 0.9.1457 still boot The browser data plane made `paused` get's second positional parameter, ahead of `write_namespace`. Computer apps exported earlier call `get(self.paths, write_namespace)`, so on 0.9.1457 and later their data/get fails and the first-boot probe fails with "get() missing 1 required positional argument". `paths` and `write_namespace` are positional again, and `paused` is a keyword the data plane passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…paused argument `get(paths, write_namespace)` takes back its original signature and freezes the app this server launched while it copies the files, through a module-level `paused_app()` that `AppRuntime.paused` now delegates to. Exported apps' own data/get hooks, which call get with two arguments, get the same one-moment copy as the built-in data plane. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6 of 22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Computer apps exported before 0.9.1457 no longer boot on 0.9.1457 or later. Their generated app code calls
app_data.get(self.paths, write_namespace). The browser data plane (#512) changed the signature toget(paths, paused, write_namespace). Sodata/getraisesget() missing 1 required positional argument: 'write_namespace', and the computer's first-boot probe fails.This restores the original signature, and keeps #512's behaviour without callers passing anything:
get(paths, write_namespace)is back as it was before feat(website-browser): the browser's data plane, data/add, data/get and data/reset (FD-4942) #512.getfreezes the app itself while it copies the files. It calls a new module-levelapp_runtime.paused_app(), which stops the launched app's process group withSIGSTOPand continues it after; it does nothing when no app is running.AppRuntime.pausednow delegates topaused_app(), so the website browser's use of it is unchanged.paused.Every caller now gets the one-moment copy #512 introduced, including exported apps' own data/get hooks.
Test plan
get(paths, None), called directly as exported apps do, returns the file and pauses and continues the running app.mainit fails with theTypeErrorabove.test_an_export_copies_the_paths_with_the_app_paused_and_sends_the_copy_once_it_runs_againstill passes.packages/agentenv-protocol/tests: 1298 passed, 1 skipped.ruff checkis clean.🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; no blocking issue was found.Summary
Restores the two-argument
app_data.get(paths, write_namespace)call used by older exported apps.Reviews (2) · Last reviewed commit: "fix(computer): get pauses the running ap..." · Reviewed by Greptile