Skip to content

feat(instance): migrate placement-group resource to API v2 - #6132

Merged
remyleone merged 7 commits into
mainfrom
instance_v2_placement_group
Oct 2, 2026
Merged

remyleone merged 7 commits into
mainfrom
instance_v2_placement_group

Conversation

@Mia-Cross

@Mia-Cross Mia-Cross commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

This PR is a duplicate from #6117, which was from a fork.
Review comments are on the original PR.

@Mia-Cross Mia-Cross self-assigned this Sep 4, 2026
@Mia-Cross Mia-Cross added enhancement instance Instance issues, bugs and feature requests priority:high New features labels Sep 4, 2026
@codecov-commenter

codecov-commenter commented Sep 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.43147% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.77%. Comparing base (f969501) to head (1886049).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...spaces/instance/v2alpha1/custom_placement_group.go 92.04% 7 Missing ⚠️
core/cobra_builder.go 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6132      +/-   ##
==========================================
- Coverage   50.78%   50.77%   -0.02%     
==========================================
  Files         359      361       +2     
  Lines       82302    82426     +124     
==========================================
+ Hits        41800    41848      +48     
- Misses      40502    40578      +76     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mia-Cross
Mia-Cross force-pushed the instance_v2_placement_group branch from 4436b86 to 26c2711 Compare September 8, 2026 12:32
@Mia-Cross
Mia-Cross marked this pull request as ready for review September 8, 2026 14:28
@Mia-Cross
Mia-Cross requested review from a team and remyleone as code owners September 8, 2026 14:28
pypaut
pypaut previously approved these changes Sep 8, 2026
pypaut
pypaut previously approved these changes Sep 9, 2026
@Mia-Cross
Mia-Cross force-pushed the instance_v2_placement_group branch from 54521d4 to 140e519 Compare September 11, 2026 13:02
@remyleone
remyleone marked this pull request as draft September 30, 2026 17:00
@Mia-Cross
Mia-Cross force-pushed the instance_v2_placement_group branch from 15c3e76 to 62b909d Compare October 2, 2026 13:47
@github-code-quality

Copy link
Copy Markdown

Code Coverage Overview

Languages: Go

Go / cli

The overall line coverage in commit 62b909d in the instance_v2_placemen... branch remains at 49%, unchanged from commit edaa36c in the main branch.

Show a line coverage summary of the most impacted files.
File main edaa36c instance_v2_placemen... 62b909d +/-
internal/namesp...instance_cli.go 91% 83% -8%
internal/namesp...ce/v1/custom.go 99% 99% 0%
core/cobra_builder.go 64% 64% 0%
internal/namesp...1/custom_web.go 100% 100% 0%
internal/namesp...lpha1/custom.go 100% 100% 0%
internal/namesp...instance_cli.go 22% 30% +8%
internal/namesp...cement_group.go 79% 100% +21%
internal/namesp...cement_group.go 0% 89% +89%
internal/namesp...1/custom_web.go 0% 100% +100%

@Mia-Cross
Mia-Cross marked this pull request as ready for review October 2, 2026 13:51
@remyleone
remyleone enabled auto-merge October 2, 2026 13:56
@remyleone
remyleone disabled auto-merge October 2, 2026 13:56
@remyleone
remyleone added this pull request to the merge queue Oct 2, 2026
Merged via the queue into main with commit 6c8fdbf Oct 2, 2026
2 checks passed
@remyleone
remyleone deleted the instance_v2_placement_group branch October 2, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement instance Instance issues, bugs and feature requests priority:high New features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants