Skip to content

feat(instance): migrate security-group resource to v2 - #6366

Merged
Mia-Cross merged 5 commits into
mainfrom
instance_v2_security_group
Nov 2, 2026
Merged

feat(instance): migrate security-group resource to v2#6366
Mia-Cross merged 5 commits into
mainfrom
instance_v2_security_group

Conversation

@Mia-Cross

@Mia-Cross Mia-Cross commented Oct 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR migrates the security-group resource to v2 of the API.

TODO :

  • add examples to generation
  • migrate cmd: clear
  • migrate cmd: create
  • migrate cmd: create-rule
  • migrate cmd: delete
  • migrate cmd: delete-rule
  • migrate cmd: edit
  • migrate cmd: get
  • migrate cmd: get-rule
  • migrate cmd: list
  • migrate cmd: list-default-rules
  • migrate cmd: list-rules
  • migrate cmd: set-rules
  • migrate cmd: update
  • migrate cmd: update-rule
  • add cmd: add-rules
  • add cmd: delete-rules

@Mia-Cross Mia-Cross self-assigned this Oct 6, 2026
@Mia-Cross Mia-Cross added enhancement instance Instance issues, bugs and feature requests priority:high New features labels Oct 6, 2026
@Mia-Cross
Mia-Cross force-pushed the instance_v2_security_group branch from 93e09ef to 253468a Compare October 6, 2026 18:17
@Mia-Cross
Mia-Cross force-pushed the instance_v2_security_group branch from 625fb2a to b748fed Compare October 15, 2026 13:13
@github-code-quality

github-code-quality Bot commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Code coverage overview

Languages: Go

Go / cli

main 2f2cfaa instance_v2_security... 39e0063 +/-
59% 59% 0%
View coverage of the 9 most impacted files.
File main 2f2cfaa instance_v2_security... 39e0063 +/-
internal/namesp...curity_group.go 61% 44% -17%
internal/namesp...instance_cli.go 81% 67% -14%
internal/namesp...ce/v1/custom.go 99% 99% 0%
internal/namesp...1/custom_web.go 100% 100% 0%
internal/namesp...lpha1/custom.go 100% 100% 0%
internal/namesp...1/custom_web.go 100% 100% 0%
internal/namesp...instance_cli.go 39% 58% +19%
internal/namesp...curity_group.go 0% 80% +80%
internal/namesp...test_helpers.go 0% 100% +100%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

Updated November 02, 2026 16:13 UTC

@Mia-Cross
Mia-Cross marked this pull request as ready for review October 15, 2026 13:54
@Mia-Cross
Mia-Cross requested review from a team and remyleone as code owners October 15, 2026 13:54
pypaut
pypaut requested changes Oct 15, 2026
View reviewed changes
Comment thread internal/namespaces/instance/v1/custom_security_group.go Resolved
Comment thread internal/namespaces/instance/v2alpha1/custom_security_group.go Resolved
Comment thread internal/namespaces/instance/v2alpha1/custom_security_group.go Resolved
Comment thread internal/namespaces/instance/v2alpha1/custom_security_group_test.go Resolved
elwinar
elwinar reviewed Oct 15, 2026
View reviewed changes
Comment thread internal/editor/editor.go Resolved
Comment thread internal/namespaces/instance/v2alpha1/custom_security_group_test.go Resolved
Comment thread internal/namespaces/instance/v2alpha1/custom_security_group_test.go Resolved
pypaut
pypaut requested changes Oct 16, 2026
View reviewed changes

@pypaut pypaut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:idk_hide:

Comment thread internal/namespaces/instance/v2alpha1/custom_security_group.go Resolved
Comment thread internal/namespaces/instance/v2alpha1/custom_security_group.go Resolved
Comment thread internal/namespaces/instance/v2alpha1/custom_security_group.go Resolved
@remyleone
remyleone marked this pull request as draft October 19, 2026 09:08
@Mia-Cross
Mia-Cross force-pushed the instance_v2_security_group branch 2 times, most recently from e7feda4 to 2423d59 Compare October 22, 2026 13:40
@Mia-Cross
Mia-Cross marked this pull request as ready for review October 22, 2026 14:02
elwinar
elwinar previously approved these changes Oct 27, 2026
View reviewed changes
Comment thread internal/namespaces/instance/v2alpha1/test_helpers.go Resolved
Comment thread internal/namespaces/instance/v2alpha1/custom_security_group_test.go Resolved
pypaut
pypaut requested changes Oct 27, 2026
View reviewed changes
Comment thread internal/editor/editor.go Resolved
@Mia-Cross
Mia-Cross force-pushed the instance_v2_security_group branch 2 times, most recently from 28228b5 to 5a9cb9b Compare October 27, 2026 14:15
@Mia-Cross
Mia-Cross requested review from elwinar and pypaut October 27, 2026 14:29
elwinar
elwinar previously approved these changes Oct 28, 2026
View reviewed changes
remyleone
remyleone reviewed Oct 28, 2026
View reviewed changes
Comment thread internal/editor/editor.go Resolved
Comment thread internal/editor/editor.go Resolved
@Mia-Cross
Mia-Cross requested a review from remyleone October 29, 2026 13:15
Mia-Cross and others added 4 commits November 2, 2026 14:41
@Mia-Cross
feat(instance): migrate security-group resource to v2
8245a49
@Mia-Cross
remove v1 tests
febca4d
@Mia-Cross @pypaut
review comments:
6d21313 
 - rename and reordering in edit test
 - comment port range logic
 - refreshSecurityGroupInfo func + fix typo in editor.go
 - remove edit test for now

Co-authored-by: Geoffrey Jount <gjount@scaleway.com>
@Mia-Cross
update goldens
ae0a2b6
@Mia-Cross
Mia-Cross force-pushed the instance_v2_security_group branch from 1c070d6 to ae0a2b6 Compare November 2, 2026 13:45
@Mia-Cross
Mia-Cross added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit c42a1af Nov 2, 2026
2 checks passed
@Mia-Cross
Mia-Cross deleted the instance_v2_security_group branch November 2, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pypaut pypaut pypaut approved these changes
@elwinar elwinar elwinar left review comments
@estellesoulard estellesoulard Awaiting requested review from estellesoulard
@remyleone remyleone Awaiting requested review from remyleone remyleone is a code owner

Assignees

@Mia-Cross Mia-Cross

Labels

enhancement instance Instance issues, bugs and feature requests priority:high New features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Mia-Cross @remyleone @elwinar @pypaut @estellesoulard