Repository navigation
test(instance): cover security-group create output format - #6477
Merged
elwinar merged 2 commits intoOct 19, 2026
Merged
Conversation
elwinar
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
Regression coverage for
scw instance security-group create -o json. The command had no test; onlysecurity-group getwas covered.Two subtests in
custom_security_group_test.go:{"security_group": {...}}shape) and exit code 0, with cleanup viaAfterFunc.Plus the four golden/cassette fixtures they replay against. No production code is touched, so there is no behaviour or compatibility change — this only pins the current output as an explicit contract.
Context
This supersedes #6158. @elwinar approved it there and asked me to sign the commits; sorry for the slow turnaround on that — the request slipped past me and the PR was closed before I came back to it. My apologies for the extra round-trip.
The content is unchanged from the branch you rebased, and the two commits are now SSH-signed.
Refs #6153