Repository navigation
Skip the Homebrew tap upload when HOMEBREW_TAP_GITHUB_TOKEN is not set - #45
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.1.1 release published its GitHub release and assets, but goreleaser then failed at the Homebrew step because HOMEBREW_TAP_GITHUB_TOKEN is not set. The template
{{ .Env.HOMEBREW_TAP_GITHUB_TOKEN }}fails when the key is missing.index .Env, so a missing key renders empty instead of failing.skip_uploadwhen the token is empty, so the formula is still generated but not pushed to the tap.HOMEBREW_TAP_GITHUB_TOKENfrom repository secrets to goreleaser, so the tap upload works once the secret is added.Validation with goreleaser v2.18.3 (the version CI used) and the variable unset:
goreleaser release --snapshot --clean --skip=signsucceeds.goreleaser checkreports only the existingbrewsdeprecation warning.A snapshot step in CI would not catch this, because snapshot mode skips the publish stage where the error happens; it passes with the old config too. So no CI step is added.
Unit tests pass apart from the DNS tests that need a resolver which fails unknown hosts; the sandbox resolves every name. CI runs them normally.