Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Composition PNGs and GIF frames ignored source-sprite and layer transforms, so a shifted sprite rendered correctly alone but stayed in its original position when composed. Apply source transforms before caching, then layer transforms before cell placement, including nested compositions. Reuse the direct-render transform parser and preserve strict errors and lenient diagnostics.
Six regressions cover direct/PNG parity, GIF frames, transform order, nested cache isolation, invalid transforms, and transformed dimensions. Both CLI regressions fail against the unchanged original base. The full test suite with
lsp,wasmand required Clippy command passed locally before stacking; validation of the combined branch is in progress.Stacked on #10, which owns the existing CI repairs. This PR's diff contains only the transform fix and its regressions. Retarget to main after #10 lands; do not merge into the prerequisite branch.