Repository navigation
fix(render): honor thickness on semantic line regions - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Semantic line regions accepted
thicknessbut always drew a one-pixel Bresenham centreline. A four-pixel line with thickness 3 now covers an 18-pixel square-brush band; omitted/thickness 1 keeps the original four pixels. This also fixes nested lines in union/subtract/intersect regions and keeps mask/validation coverage consistent with rendering.Defines centred odd widths, a deterministic negative-side bias for even widths and an empty width-zero line. Adds odd/even/default/zero/diagonal/compound controls and an end-to-end PNG/mask/z-order/clipping test; strict clipping still reports a warning.
Validation: 2,607 passing tests across 21 native test executables with
lsp,wasm, clippy all-targets with warnings denied, formatting and demo-documentation check. Native feature testing is not a browser-WASM claim; hosted CI runs the remaining surfaces.Demo (sanitized transcript of the same local 8x8 fixture, base
686b366versus head4802322):Reproduce with
cargo test --test line_thickness --features lsp,wasm, or render a region{line:[[2,4],[5,4]],thickness:3}on an 8x8 canvas, thenpxl mask fixture.pxl --sprite thick --count --json. The transcript reports actual local candidate behavior; it is not an installed release claim. A replayable terminal capture is retained privately; no public recording host is configured.Bead: aegis-8t76.1
Overlap preflight: 4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945
Current integration refresh
c6939d4e9d44145b022195143081284b4da08f8eincludes basec665831cafter the publishing repair landed. The entire three-path line-thickness proposal replays forward and inverse exactly, with no behavior changes in the refresh. The line-thickness PNG/mask control passes at this candidate; fresh hosted CI remains required. Earlier test-launch attempts stopped before testing because the sandbox lacked toolchain configuration; the successful run uses explicit compiler paths, with HOME guard verification retained privately. No release, tag, publication or product installation is requested.