Move LabRecorder into the monorepo as a component - #12
Merged
neuromechanist merged 2 commits intoJul 19, 2026
Conversation
Vendored at apps/LabRecorder/ from neuromechanist/Secure-LabRecorder branch feature/security-status, based on upstream 684df66. Per the component licensing policy, upstream's MIT license (Copyright (c) 2012 Christian Kothe) is restored over the fork's proprietary replacement, and the README license section is corrected to match. The fork's "Update license to proprietary" commits are deliberately not carried across: the security integration reads stream status through the public LSL API and contains no cryptographic implementation, so nothing in this component requires the proprietary grant. - COMPONENT.md records upstream provenance and base commit - THIRD-PARTY-NOTICES.md gains the LabRecorder entry - docs/integration/labrecorder.md documents building the in-repo component alongside the existing drop-in route, which stays the zero-change path; the LSL_INSTALL_ROOT flag was checked against the component's CMakeLists before documenting it - Dropped vendored .github workflows so upstream CI does not fire here Closes #9
8 tasks
8 tasks
neuromechanist
deleted the
9-move-labrecorder-into-the-monorepo-as-a-component
branch
July 19, 2026 19:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9. Second of three component moves (#8 pylsl in #11, #10 SigVisualizer next).
What moved
neuromechanist/Secure-LabRecorderbranchfeature/security-status(based on upstream684df66) is vendored atapps/LabRecorder/.Licensing
Upstream's MIT license is restored (Copyright (c) 2012 Christian Kothe) over the proprietary replacement the fork had applied, and the README license section is corrected to match. The fork's
b4fe41e "Update license to proprietary"andf91e57f "Add proprietary license section to README"are deliberately not carried across.This follows the COMPONENT LICENSING POLICY from #7 and is accurate to what the code is: the security integration is 257 lines of security-status display, About-dialog version info, and mismatch dialogs, all reading through the public LSL API, with zero references to sodium, ChaCha, or Ed25519. There is no cryptographic implementation here, so nothing requires the proprietary grant.
Also in this PR
apps/LabRecorder/COMPONENT.mdwith upstream URL and base commitTHIRD-PARTY-NOTICES.mdentry with the verbatim MIT textdocs/integration/labrecorder.mdgains a section on building the in-repo component. The existing drop-in library-replacement route is kept rather than replaced, since that remains the zero-change path to encrypted recording; the component adds the visibility layer on top..github/so upstream CI does not fire hereThe
LSL_INSTALL_ROOTflag in the documented build command was checked againstapps/LabRecorder/CMakeLists.txt, where it is used as afind_package(LSL ...)hint, before being written into the docs.