esp32-s3: device-test reports and matches the release tag - #69
Merged
Conversation
Show the release tag in parentheses after the SHA in the firmware version INFO line, and accept either the SHA or the tag for --expect-version. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WYzZp3e4k3uotTRZcrasZE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to #63, which added the release tag alongside the SHA in the firmware JSON.
firmware version ad7fb58 (v1.2.0)), and is unchanged when the build carries no tag.--expect-versionaccepts either the short SHA or the release tag; help text and metavar updated.Not run against bench hardware — the change is confined to the
--statusreporting path.🤖 Generated with Claude Code
https://claude.ai/code/session_01WYzZp3e4k3uotTRZcrasZE