Skip to content

Fix repeated lines during jaspr create rendering mode prompt - #855

Open
zeykafx wants to merge 3 commits into
schultek:mainfrom
zeykafx:cli-prompt-repeated-lines
Open

Fix repeated lines during jaspr create rendering mode prompt#855
zeykafx wants to merge 3 commits into
schultek:mainfrom
zeykafx:cli-prompt-repeated-lines

Conversation

@zeykafx

@zeykafx zeykafx commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Description

This fixes a rendering bug when using jaspr create where the rendering mode prompt would be re-printed on every key press. This is due to a bug in mason_logger (see felangel/mason#1356) that causes the list of choices to be reprinted to the terminal if the terminal has scrolled. A workaround is to clear the entire terminal, however this is not the behavior expected by users. The workaround here scrolls down enough to make space for the choices, then moves back up.

Before (pressed down arrow twice):
CleanShot 2026-08-04 at 12  36 28@2x
After (pressed down arrow twice):
CleanShot 2026-08-04 at 12  37 01@2x

Type of Change

  • 🛠️ Bug fix

Ready Checklist

  • I've read the Contribution Guide.
  • In case this PR changes one of the core packages, I've modified the respective CHANGELOG.md file using
    the semantic_changelog format.
  • I updated/added relevant documentation (doc comments with ///).
  • I added myself to the AUTHORS file (optional, if you want to).

@zeykafx
zeykafx requested a review from schultek as a code owner August 4, 2026 10:43
@zeykafx zeykafx changed the title Cli prompt repeated lines Fix repeated lines during jaspr create rendering mode prompt Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Package Version Report

The following packages have been updated:
jaspr_test : 0.23.2 -> 0.23.3
jaspr : 0.23.2 -> 0.23.3
jaspr_builder : 0.23.2 -> 0.23.3
jaspr_cli : 0.23.2 -> 0.23.3
jaspr_router : 0.8.3 -> 0.9.0
jaspr_content : 0.5.3+1 -> 0.5.4

@zeykafx

zeykafx commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Ah, I see that the next branch fixed this issue. @schultek when do you reckon next will be merged into main? I fixed another bug where the build daemon error logs wouldn't show up, but I suppose that making a PR for that is not useful then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant