Fix repeated lines during jaspr create rendering mode prompt - #855
Open
zeykafx wants to merge 3 commits into
Open
Fix repeated lines during jaspr create rendering mode prompt#855zeykafx wants to merge 3 commits into
zeykafx wants to merge 3 commits into
Conversation
Package Version ReportThe following packages have been updated: |
Contributor
Author
|
Ah, I see that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a rendering bug when using
jaspr createwhere the rendering mode prompt would be re-printed on every key press. This is due to a bug inmason_logger(see felangel/mason#1356) that causes the list of choices to be reprinted to the terminal if the terminal has scrolled. A workaround is to clear the entire terminal, however this is not the behavior expected by users. The workaround here scrolls down enough to make space for the choices, then moves back up.Before (pressed down arrow twice):


After (pressed down arrow twice):
Type of Change
Ready Checklist
the semantic_changelog format.
///).