Repository navigation
Fix the startup hang and the issues found while debugging - #590
Merged
Merged
Conversation
The absences page reloads its target when the linked accounts change, and resolving the target loads them when none are loaded. load() notified before its first await, so the listener called load() again in the same stack: a synchronous loop on the UI thread that froze every signed-in launch on the spinner and grew the heap until it was exhausted. A load now joins one in flight, including during its final notification, so a failed load is not retried by its own listener.
Closes #513. The dashboard builds its pages as const, so rebuilding the dashboard never reached them: home, grades and absences kept what they saw on first build until the app restarted, and the timetable stopped updating once it had picked a day. Each page now follows SchoolDataService itself.
Grades whose exam was not in the upcoming-exams list vanished, exams had no date or class, the grade sections had no names, holidays arrived as lessons, and upcoming exams were missing from the timetable. The adapter now maps what the stateless routes already send.
One failing endpoint threw away the whole refresh, and the five requests ran one after the other. They now run together, a failed section stays empty with a notice, and the last complete snapshot is kept on disk.
Image.network cannot decode SVG, so a provider whose IconUrl is an SVG showed no icon. Adds flutter_svg and a RemoteIcon widget that handles both raster and SVG, with either URL shape.
Closes #470. Release builds no longer carry the developer LAN addresses or allow plain HTTP. The dev flavor overrides the config and keeps its local backends.
The dashboard spinner had no end while requests could take minutes, and failures showed a raw exception with no way out. A slow load now offers a retry after 30 seconds, and failures read as a sentence with a retry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stopped the accounts load from re-entering itself, fixed the dashboard not updating after the first sync, showed more data in private mode, added retries to loading screens, drew SVG sign-in icons, limited cleartext traffic to the dev flavor, and removed dead code.
Closes #589
Closes #513
Closes #470
Closes #515