Skip to content

Raise solution description limit to 600 characters - #401

Merged
PavlosIsaris merged 1 commit into
masterfrom
hotfix/solution-description-limit-master
Sep 15, 2026
Merged

PavlosIsaris merged 1 commit into
masterfrom
hotfix/solution-description-limit-master

Conversation

@PavlosIsaris

@PavlosIsaris PavlosIsaris commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Cherry-pick of the production hotfix that raises the solution description limit from 400 to 600 characters, so master and production do not drift.

  • resources/views/solution/partials/new-solution-form.blade.php: maxlength, character counter and label now use 600.
  • resources/views/backoffice/management/solution/create-edit/partials/basic-details.blade.php: maxlength now 600.
  • app/Http/Controllers/Solution/SolutionController.php: backoffice update rule changed from max:410 to max:600.

Three feature tests cover the 600/601 boundary on the public proposal store and the backoffice update.

Summary by CodeRabbit

  • New Features

    • Increased the maximum allowed solution description length to 600 characters across solution forms.
    • Updated the character counter to reflect the 600-character limit.
  • Bug Fixes

    • Validation now consistently accepts descriptions up to 600 characters and rejects longer entries.
  • Tests

    • Added coverage for the updated description length limits.

Align the solution description limit with the problem description
limit. The public proposal form and the backoffice form capped input
at 400 characters in the browser, while the backoffice update rule
allowed 410. All three now allow 600, matching the existing rules for
public proposal store and backoffice create.

Add feature tests for the 600/601 boundary on both the public proposal
store and the backoffice update.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
(cherry picked from commit 6454a86)
@sonarqubecloud

Copy link
Copy Markdown

@codecov-commenter

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@coderabbitai

coderabbitai Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 31822319-2567-4098-9310-4df696275d9d

📥 Commits

Reviewing files that changed from the base of the PR and between 409f314 and 0764126.

📒 Files selected for processing (4)
  • app/Http/Controllers/Solution/SolutionController.php
  • resources/views/backoffice/management/solution/create-edit/partials/basic-details.blade.php
  • resources/views/solution/partials/new-solution-form.blade.php
  • tests/Feature/Controllers/Solution/SolutionControllerTest.php

Walkthrough

The solution description limit increased to 600 characters in update validation and both solution forms. Feature tests cover the 600-character boundary and reject 601-character descriptions.

Changes

Solution description limit

Layer / File(s) Summary
Description limit behavior
app/Http/Controllers/Solution/SolutionController.php, resources/views/.../basic-details.blade.php, resources/views/solution/partials/new-solution-form.blade.php
Update validation, textarea limits, and the live character counter now allow up to 600 characters.
Description limit validation coverage
tests/Feature/Controllers/Solution/SolutionControllerTest.php
Tests reject 601-character descriptions for proposals and administrator updates. Tests accept and persist an administrator update with exactly 600 characters.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hotfix/solution-description-limit-master

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@PavlosIsaris
PavlosIsaris merged commit fe717a3 into master Sep 15, 2026
9 of 10 checks passed
@PavlosIsaris
PavlosIsaris deleted the hotfix/solution-description-limit-master branch September 15, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants