Repository navigation
Interface SCIP methods missing from PySCIPOpt - #1285
Merged
Merged
Conversation
adamj34
marked this pull request as ready for review
November 8, 2026 13:29
Member
|
Thank you so much @adamj34 ! One minor question: when the model is solved to optimality, things like |
adamj34
marked this pull request as draft
November 10, 2026 19:47
… to indicate possible None return values
adamj34
marked this pull request as ready for review
November 10, 2026 21:23
Contributor
Author
|
That's a good catch, @Joao-Dionisio. |
Contributor
Author
|
I also added one more method |
Joao-Dionisio
enabled auto-merge
November 11, 2026 09:00
Joao-Dionisio
approved these changes
Nov 11, 2026
Joao-Dionisio
left a comment
Member
There was a problem hiding this comment.
Thank you so much, @adamj34 , awesome PR as always!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following methods:
nodesSharePath(), nodesGetCommonAncestor(), getFocusDepth(), getRootNode(), wasNodeLastBranchParent()Adds tests in
tests/test_node.pyandtests/test_node_methods.pyfor the interfaced methodsAdds function signatures to
scip.pyifor type hintsUpdates
CHANGELOG.md