-
Notifications
You must be signed in to change notification settings - Fork 2
refactor: use parameter models from esslivedata #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jokasimr
wants to merge
1
commit into
main
Choose a base branch
from
refactor-widget-models
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| # SPDX-License-Identifier: BSD-3-Clause | ||
| # Copyright (c) 2024 Scipp contributors (https://github.com/scipp) | ||
| """Default parameter specs for BEER workflows.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from math import pi | ||
|
|
||
| from ess.powder.masking import with_pixel_mask_filenames | ||
| from ess.powder.types import ( | ||
| CalibrationFilename, | ||
| DspacingBins, | ||
| EmptyCanRun, | ||
| Filename, | ||
| IntensityDspacing, | ||
| IntensityDspacingTwoTheta, | ||
| MaskedDetectorIDs, | ||
| MonitorFilename, | ||
| NeXusDetectorName, | ||
| PixelMaskFilename, | ||
| ReducedTofCIF, | ||
| SampleRun, | ||
| TwoThetaBins, | ||
| UncertaintyBroadcastMode, | ||
| VanadiumRun, | ||
| ) | ||
|
|
||
| from ess.reduce.parameter import ParameterRegistry, ParameterSpec | ||
| from ess.reduce.parameter_models import AngleUnit, DspacingEdges, TwoTheta | ||
|
|
||
| from .types import DetectorBank | ||
|
|
||
|
|
||
| def _edges(model): | ||
| return model.get_edges() | ||
|
|
||
|
|
||
| parameters = ParameterRegistry() | ||
|
|
||
| parameters[Filename[SampleRun]] = ParameterSpec( | ||
| model=str | None, | ||
| category='Files', | ||
| title='Sample Run', | ||
| default=None, | ||
| ) | ||
| parameters[Filename[VanadiumRun]] = ParameterSpec( | ||
| model=str | None, | ||
| category='Files', | ||
| title='Vanadium Run', | ||
| default=None, | ||
| ) | ||
| parameters[Filename[EmptyCanRun]] = ParameterSpec( | ||
| model=str | None, | ||
| category='Files', | ||
| title='Empty Can Run', | ||
| default=None, | ||
| ) | ||
| parameters[CalibrationFilename] = ParameterSpec( | ||
| model=str | None, | ||
| category='Files', | ||
| title='Calibration', | ||
| default=None, | ||
| ) | ||
| parameters[MonitorFilename[SampleRun]] = ParameterSpec( | ||
| model=str | None, | ||
| category='Files', | ||
| title='Sample Monitor', | ||
| default=None, | ||
| ) | ||
| parameters[PixelMaskFilename] = ParameterSpec( | ||
| model=tuple[str, ...], | ||
| category='Files', | ||
| title='Pixel Masks', | ||
| default=(), | ||
| apply=with_pixel_mask_filenames, | ||
| filter_keys=(MaskedDetectorIDs, PixelMaskFilename), | ||
| ) | ||
|
|
||
| parameters[NeXusDetectorName] = ParameterSpec( | ||
| model=str, | ||
| category='NeXus', | ||
| title='Detector', | ||
| default='detector', | ||
| ) | ||
|
|
||
| parameters[DspacingBins] = ParameterSpec( | ||
| model=DspacingEdges, | ||
| category='Binning', | ||
| title='D-spacing Edges', | ||
| default=DspacingEdges(start=0.0, stop=2.0, num_bins=200), | ||
| transform=_edges, | ||
| use_workflow_default=False, | ||
| ) | ||
| parameters[TwoThetaBins] = ParameterSpec( | ||
| model=TwoTheta, | ||
| category='Binning', | ||
| title='Two-Theta Edges', | ||
| default=TwoTheta(start=0.0, stop=pi, num_bins=180, unit=AngleUnit.RADIAN), | ||
| transform=_edges, | ||
| use_workflow_default=False, | ||
| ) | ||
|
|
||
| parameters[UncertaintyBroadcastMode] = ParameterSpec( | ||
| model=UncertaintyBroadcastMode, | ||
| category='Reduction', | ||
| title='Uncertainty Broadcast', | ||
| default=UncertaintyBroadcastMode.upper_bound, | ||
| ) | ||
| parameters[DetectorBank] = ParameterSpec( | ||
| model=DetectorBank, | ||
| category='Reduction', | ||
| title='Detector Bank', | ||
| default=DetectorBank.south, | ||
| ) | ||
|
|
||
|
|
||
| typical_outputs = ( | ||
| IntensityDspacing[SampleRun], | ||
| IntensityDspacingTwoTheta[SampleRun], | ||
| ReducedTofCIF, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes will be revisited or removed.
They were added mainly for debugging purposes.