Use portable JSON SQL so the server runs on MariaDB as well as MySQL - #16
Open
hal-niner wants to merge 1 commit into
Open
Use portable JSON SQL so the server runs on MariaDB as well as MySQL#16hal-niner wants to merge 1 commit into
hal-niner wants to merge 1 commit into
Conversation
The item, user, and feed queries extract prefs fields with the ->> operator, which MySQL supports but MariaDB does not -- on MariaDB every one of those queries fails with ER_PARSE_ERROR, so timelines and feeds come up empty. json_unquote(json_extract(col, '$.path')) is the exact equivalent, standard in both engines; MySQL's own docs define ->> as shorthand for it. All ten uses rewritten; no behavior change on MySQL. Running in production on a MariaDB instance (perstitio.us) since 7/18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The item, user, and feed queries extract prefs fields with the ->> operator, which MySQL supports but MariaDB does not -- on MariaDB every one of those queries fails with ER_PARSE_ERROR, so timelines and feeds come up empty. json_unquote(json_extract(col, '$.path')) is the exact equivalent, standard in both engines; MySQL's own docs define ->> as shorthand for it. All ten uses rewritten; no behavior change on MySQL. Running in production on a MariaDB instance (perstitio.us) since 7/18.