Make the PubChem compound annotation test robust to outages - #1111
Merged
Merged
Conversation
pubchempy converts PubChem 404s into empty results, so a transient outage surfaces as a "no matches" ValueError from annotate_compounds, which the retry loop did not catch (daily integration run, #1108). Retry on ValueError too, annotate a copy per attempt, and skip with the reason after the last retry instead of silently passing.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1111 +/- ##
==========================================
+ Coverage 79.98% 80.12% +0.14%
==========================================
Files 55 55
Lines 7518 7571 +53
==========================================
+ Hits 6013 6066 +53
Misses 1505 1505 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1108.
The compound annotation test now retries when PubChem returns empty results (which pubchempy surfaces as a no-match
ValueError), and skips with the reason instead of silently passing after the last retry, so transient PubChem outages no longer fail CI.