[WIP] Network Mounted Volumes - docker based solution - #224
Open
angad-k wants to merge 1 commit into
Open
Conversation
dockerozed seaweedfs, doesn't change any database behaviour as of now no breaking changes
angad-k
changed the title
karan0299
requested changes
Oct 26, 2020
karan0299
left a comment
karan0299
left a comment
Contributor
There was a problem hiding this comment.
Few requested changes
Rest L.G.T.M
| } | ||
| } | ||
|
|
||
| func setupSeaweedfsContainer(serviceName string) { |
Contributor
There was a problem hiding this comment.
In this function change serviceName -> seaweedType
| utils.LogInfo("No %s instance found in host. Building the instance.", strings.Title(serviceName)) | ||
| containerID, err := seaweedfs.SetupSeaweedfsInstance(serviceName) | ||
| if err != nil { | ||
| utils.Log("There was a problem deploying %s service.", strings.Title(serviceName), utils.ErrorTAG) |
Contributor
There was a problem hiding this comment.
Suggested change
| utils.Log("There was a problem deploying %s service.", strings.Title(serviceName), utils.ErrorTAG) | |
| utils.Log("There was a problem deploying %s seaweedType", strings.Title(serviceName), utils.ErrorTAG) |
| if containerCfg.Name == types.SeaweedFiler { | ||
| err := os.MkdirAll("seaweed/seaweed-filer-storage/filerldb2", 0777) | ||
| if err != nil { | ||
| println(err.Error()) |
Contributor
There was a problem hiding this comment.
Shouldn't here be return statement instead of print
| }, | ||
| PortBindings: nat.PortMap{ | ||
| nat.Port(containerPortRule1): []nat.PortBinding{{ | ||
| HostIP: "", |
Contributor
There was a problem hiding this comment.
Suggested change
| HostIP: "", | |
| HostIP: "0.0.0.0", |
| HostIP: "", | ||
| HostPort: fmt.Sprintf("%d", containerCfg.ContainerPort1)}}, | ||
| nat.Port(containerPortRule2): []nat.PortBinding{{ | ||
| HostIP: "", |
Contributor
There was a problem hiding this comment.
Suggested change
| HostIP: "", | |
| HostIP: "0.0.0.0", |
| func startMasterService() error { | ||
|
|
||
| checkAndPullImages("chrislusf/seaweedfs") | ||
| err := os.MkdirAll("seaweed/seaweed-filer-storage/filerldb2", 0777) |
Contributor
There was a problem hiding this comment.
What does ldb2 signify in filerldb2 ? and Is it necessary to name it so
| //SeaweedCronjob is the cronjob service for Seaweedfs | ||
| SeaweedCronjob = "seaweed_cronjob" | ||
|
|
||
| //SeaweedS3 is the Seaweed service that provides support for AmazonS3 |
Contributor
There was a problem hiding this comment.
@supra08 Is support for AmazonS3 required for our use case? In future may be?
| Image string | ||
| // Port on which a database service is running inside the container | ||
| HostPort1 int | ||
| // Port on which a database service is running inside the container |
Contributor
There was a problem hiding this comment.
Can you change Comment to distinguish HostPort1 and HostPort2
| ContainerPort1 int | ||
| // Port of the docker container in the host system | ||
| ContainerPort2 int | ||
| // Directory inside the docker container for volume mounting purposes |
Contributor
There was a problem hiding this comment.
Similarly for ContainerPort1 and ContainerPort2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disregard the previous PR. The work for this is mostly completed. Once the next seaweedFS release happens (which usually does every 5-6 days), I'll rebuild the docker images for the databases and then include those images instead of the current ones we are using.