Repository navigation
fix(ci): use $name in archive template for multi-binary packaging - #12
Merged
Merged
Conversation
taiki-e/upload-rust-binary-action refuses \`\$bin\` when the \`bin\` input lists multiple binaries — it can't choose which one to name the combined archive after. Replace with \`\$name\` (the Cargo.toml package name), so the archives come out as \`rat-rat-v0.4.0-<target>.tar.gz\`. Unblocks the v0.4.0 binaries (currently unattached) and any future release. Use workflow_dispatch with \`release_tag=rat-v0.4.0\` after this merges to retro-upload v0.4.0's tarballs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`taiki-e/upload-rust-binary-action` rejects `$bin` in the archive template when `bin:` lists multiple binaries — ambiguous naming. v0.4.0 shipped without tarballs for exactly this reason:
```
##[error]when multiple binary names are specified, default archive name or '$bin' variable cannot be used in 'archive' option
```
Swap to `$name` (Cargo.toml package name). Archives come out as `rat-rat-v0.4.0-.tar.gz`.
After merge
Trigger the workflow with `workflow_dispatch` + `release_tag=rat-v0.4.0` to retro-upload v0.4.0's four tarballs without needing a new release.
```sh
gh workflow run release-please.yml -f release_tag=rat-v0.4.0
```