Skip to content

add auth header to storage-server - #933

Open
AlexCXC wants to merge 1 commit into
masterfrom
fix-storage-server-auth
Open

AlexCXC wants to merge 1 commit into
masterfrom
fix-storage-server-auth

Conversation

@AlexCXC

@AlexCXC AlexCXC commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@seafile-dev seafile-dev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

审查结论:通过。本结论仅针对当前 PR 的调用方改动,未发现需要新增行内评论的阻塞问题。

已检查全部 storage HTTP 调用均携带 Authorization,并使用真实 PyJWT、requests 与配套 storage-server #84 当前源码的 Go 路由及 JWT 中间件完成本地 HTTP 契约验证:Base 读写、备份下载/流式下载/上传/删除均通过,错误签名被拒绝;有效期、audience 和算法与接收方一致。测试使用合成配置与本地临时文件,并替换接收方存储/数据库处理器,不代表完整事件任务或持久化集成验收。

任务未提供可识别的设计文档链接。发布时须先更新全部调用方,再启用 storage-server 强制鉴权,并保证各组件 JWT_PRIVATE_KEY 一致;仅合入本 PR 不会阻止旧 storage-server 的匿名访问。

审查提交:98fd94462a4209f074c9d4228bb66aeea4992ce9。发布前重新读取的当前提交 CI:job 134628154496:in_progress / 尚无结论。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants