Repository navigation
Conversation
seafile-dev
approved these changes
Nov 18, 2026
seafile-dev
left a comment
There was a problem hiding this comment.
审查结论:通过。本结论仅针对当前 PR 的调用方改动,未发现需要新增行内评论的阻塞问题。
已检查全部 storage HTTP 调用均携带 Authorization,并使用真实 PyJWT、requests 与配套 storage-server #84 当前源码的 Go 路由及 JWT 中间件完成本地 HTTP 契约验证:Base 读写、备份下载/流式下载/上传/删除均通过,错误签名被拒绝;有效期、audience 和算法与接收方一致。测试使用合成配置与本地临时文件,并替换接收方存储/数据库处理器,不代表完整事件任务或持久化集成验收。
任务未提供可识别的设计文档链接。发布时须先更新全部调用方,再启用 storage-server 强制鉴权,并保证各组件 JWT_PRIVATE_KEY 一致;仅合入本 PR 不会阻止旧 storage-server 的匿名访问。
审查提交:98fd94462a4209f074c9d4228bb66aeea4992ce9。发布前重新读取的当前提交 CI:job 134628154496:in_progress / 尚无结论。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.