Repository navigation
Fix TwitchDownloaderCLI detection and GetHistory for imported channels - #3
Merged
Merged
Conversation
…l redirect arg - Remove "2>&1" from TwitchDownloader version_args in Software.ts; it was passed as a literal argument to spawn() rather than interpreted as a shell redirect, causing the version regex to fail to match - Add libicu76 to apt-get install in Dockerfile; TwitchDownloaderCLI is a .NET 8 self-contained binary that requires ICU libraries for globalization, which were missing from the Debian Trixie slim image (the old Alpine config explicitly included icu-libs but the migration dropped it) - Update docker-compose.yml image reference to ghcr.io/second2falcon/livestreamdvr:latest Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018ynVqCD9HyYB2nSqpTUwFa
… file exists Channels imported from another system never trigger the live-capture writes that build the per-channel .jsonline history file, so Fetch History always returned 400 "No history found" for them even with 77 recorded VODs. When the history file is absent, collect chapters_raw from all of the channel's loaded VODs, sort them by started_at, and return those instead. The 400 error is preserved only when there are genuinely no VODs with chapters either. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018ynVqCD9HyYB2nSqpTUwFa
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018ynVqCD9HyYB2nSqpTUwFa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"2>&1"was passed as a literal argument tospawn()inDVRBinaries(), not interpreted as a shell redirect, causing the version regex to never matchlibicu76was missing from the Dockerfile apt-get install; TwitchDownloaderCLI is a .NET 8 self-contained binary that requires ICU libraries (the old Alpine config hadicu-libsbut the Debian Trixie migration dropped it).jsonlinefile is only written during live captures, so channels imported from another system always got "No history found". The endpoint now falls back to the last 5 VODs'chapters_rawdata when the file is absent, returning 400 only if there are genuinely no chapters at all.docker-compose.ymlimage reference toghcr.io/second2falcon/livestreamdvr:latestChanges
server/src/Helpers/Software.ts"2>&1"from TwitchDownloaderversion_argsDockerfilelibicu76to apt-get installdocker-compose.ymlserver/src/Controllers/Channels.tsGetHistorywhen no live-capture history file existshttps://claude.ai/code/session_018ynVqCD9HyYB2nSqpTUwFa
Generated by Claude Code