Ajuste no tipo de instrumento obrigatório no edital

[jeff-doliveira1]

✅ Descrição do propósito desse Pull Request

---

🧭 Referência a Issue

---

❓ O que foi feito para atingir isso?

---

🏃‍♀️ Tipo de mudança

Marque as opções relevantes:

• Bug fix (correção de bug)
• Nova feature (mudança não retrocompatível que adiciona funcionalidade)
• Mudança de breaking (correção ou feature que faria com que a funcionalidade existente não funcionasse como esperado)
• Documentação (somente mudanças ou atualizações na documentação)

---

🕵️ Como foi testado?

• Critério de aceitação
• Testes de software (TDD, BDD, UNITÁRIO, INTEGRAÇÃO, E2E)

---

Checklist: ✔️

• Meu código segue as diretrizes do projeto
• Eu fiz um code review com minha equipe
• Eu comentei meu código, especialmente em áreas de difícil entendimento
• Eu atualizei a documentação correspondente
• Testes novos e existentes passaram localmente com minhas alterações

---

Observação:

Summary by CodeRabbit

• Bug Fixes
  • Users without the super admin role can now set an instrument type when a notice does not already have one.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: secultce/efomento/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: c812f3ba-5b53-4efa-8de5-8dfaef4153fa

📥 Commits

Reviewing files that changed from the base of the PR and between 8584142 and 62eb917.

📒 Files selected for processing (1)

• app/Http/Requests/Notice/NoticeUpdateRequest.php

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The instrument type update validation now checks that the notice has a truthy current value before rejecting a change for a user without the super-admin role.

Changes

Instrument type update

Layer / File(s)	Summary
Instrument type validation app/Http/Requests/Notice/NoticeUpdateRequest.php	The validation rejects a changed instrument type for users without the super-admin role only when the current value is truthy. An empty current value no longer triggers the permission failure.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: caffeineissues

Merge Risk: ⚪ Minimal · up to 62eb9

Users can make an initial instrument type assignment, while changing an existing valid type remains restricted to super-admins. No actionable merge risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	O título descreve de forma clara e concisa a alteração na validação do tipo de instrumento no edital.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}