Repository navigation
Anisotropic filtering: a launcher choice of 2x to 16x for NVN games, checked in Breath of the Wild - #2418
Open
dontpokethebear3893 wants to merge 3 commits into
Conversation
…e game's mipmapped linear samplers get at least 2x to 16x Breath of the Wild's material samplers ask for 1x (one for 2x), so ground and walls seen at a slant blur a few metres out, most visibly at 4K and above. DM_ANISO=2..16 raises the anisotropy of samplers with a linear magnification filter, a linear minification filter with mip selection and more than one level; comparison (shadow) samplers, min / max reductions and samplers held to one level keep the game's. off (the default) changes nothing. As the anisotropy option of Cemu's graphic packs for the Wii U version. t_aniso checks which samplers the registry raises. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2 of 3 tasks
Brings the branch up to date with main (fixes for the t_save_sync cloud device check and the clang-tidy fixture findings, among others) and resolves the conflicts with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Breath of the Wild's material samplers ask for 1x anisotropy (one asks for 2x). Ground, paths and walls seen at a slant blur a few metres from the camera, and the larger the picture (4K, 5K), the more it shows. This adds an Anisotropic filtering choice to the launcher (Game): Game's own (the default), 2x, 4x, 8x, 16x.
nvn_mtl.m):DM_ANISO=2..16is a floor for the anisotropy of the samplers that pick a mip level with linear filtering: a linear magnification filter, a linear minification filter with mip selection, and more than one level. Comparison (shadow) samplers, min / max reduction samplers and samplers held to one level keep the game's value.offchanges nothing. The same idea as the anisotropy option of Cemu's graphic packs for the Wii U version.settings.tsvrow, shown for every NVN game. Only Breath of the Wild was run with it (see Not checked).Conflict with #2419 (Shadow resolution): both add a line at the same place in the game's README, in
settings.tsv, and indocs/settings.md(the contents line and a new section). Whichever goes in second keeps both sides; I will rebase it.Front ends
Front-ends: none (one more choice row in
launcher.json, nothing new in the schema).Checked
mainc24ab14): a build ofmainwith this change and Breath of the Wild: a Shadow resolution choice (150%, 200%) for sharper sun shadows at 4K and 5K #2419, the game's default 1080p, the Mac's screen locked:anisotropic filtering: first sampler raised to 16x (sampler 258, the game's 1), and a screenshot at frame 3000 shows the scene as it should be.dm/gfx/testscheck_t_aniso(new, 21 checks: which samplers the registry raises and which it leaves) andcheck_t_border(113 checks) pass.dm/tools/testspasses:test_docs,test_env_switches,test_settings,test_launcher_settings,test_game_profile,test_patches,test_player_env,test_fps_target,test_nsp_mac_app,test_lint_candtest_gfx_tests_makefile.lint_python.py --against origin/main: no new findings.regress.py check --games: not run. With the switch off (the default) no sampler is changed, and I have only this game.Docs
docs/settings.md(Anisotropic filtering), the switch indocs/env_switches.tsv, and a note in the game's README (dm/games/01007EF00011E000/README.md);docs_symptoms.pywas run and changes nothing🤖 Generated with Claude Code