Repository navigation
game: add experimental Breath of the Wild display options - #2809
Draft
reis-lucas wants to merge 1 commit into
Draft
reis-lucas wants to merge 1 commit into
reis-lucas wants to merge 1 commit into
Conversation
Keep the original aspect and resolution defaults, expose opt-in Mac widescreen and docked resolution settings, center the HUD, preserve decoded movie proportions, and keep textured map layers aligned with their markers. Inventory portraits and captured-menu transitions remain open. Front-ends: expose DM_WIDESCREEN for CAMERA_ASPECT and DM_RENDER_RESOLUTION for RENDER_RESOLUTION, on Mac only; defaults are zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Add opt-in Mac display controls for Breath of the Wild 1.9.0 while preserving the original 16:9 and render-resolution defaults. The camera uses the drawable aspect, the HUD remains centered, and docked 3D resolution can be raised independently to 1080, 1200 or 1440 lines. Both controls require the corresponding verified-build capability.
This is a draft, not a claim of complete ultrawide compatibility. Textured map layers now receive the same centering transform as their markers; decoded movies retain their original aspect using the existing movie-pacing signal. Full-width solid fades/backings remain eligible to cover the sides.
Remaining blockers: inventory Link has a separate camera and can appear stretched; pause-menu captures and L/R transitions can show duplicate/clipped layers; in-engine event cameras have not been validated. Attempts to squeeze every rendered picture introduced additional compositing defects and were rejected. The Slate is deliberately centered at 16:9 with side margins, rather than stretching its map or decoration. Other aspect ratios and a full playthrough remain unverified.
Camera/UI work adapts ComicBit's
zelda-native-widescreenbranch and credits MacNativeGames (MIT). Resolution/render-pool sites credit v0lumehi/nxnative PR #76. The new state words avoid the existing render-scale and taller-screen fields.Checked
01007EF00011E000, v1114112 / 1.9.0, M4 Pro 48 GB, macOS 27.2.1. Manual tests used copied saves and a 1290x540 window matching 3440x1440's aspect ratio.t_dlss_scaler.m; reproduced on pristine upstream23790f8d.test_env_switches, reproduced on pristine upstream), 16 skipped.Only BOTW is selected for runtime regression: only its verified build advertises the new capabilities; other games stay on the zero/default path. The impact report also names shared NVN entry points, so broader game coverage and iOS remain unchecked.
Front ends
Front-ends: expose
DM_WIDESCREENforCAMERA_ASPECTandDM_RENDER_RESOLUTIONforRENDER_RESOLUTIONon Mac. Both default to zero; resolution choices are 0/1080/1200/1440. The bundled settings UI supports both and keeps the HUD centered.Docs
dm/games/01007EF00011E000/README.md; settings and generated patch documentation are updated.Initial full regression report
regress.py check (full): REGRESSION
Baseline
23790f8d23790f8, candidateworktree23790f8 (+ uncommitted changes); Apple M4 Pro, macOS 27.2.1, Xcode 27.2; 617.2 s01007EF00011E000The Legend of Zelda Breath of the Wild
01007EF00011E000: REGRESSIONWarmed two-run comparison
The candidate is commit
b5843287. Both revisions used the same warmed pipeline archive, with two 110-second runs each. This is a default-settings check, not a benchmark of the optional higher-resolution mode.regress.py check (full): REGRESSION
Baseline
23790f8d23790f8, candidateworktreeb584328; Apple M4 Pro, macOS 27.2.1, Xcode 27.2; 462.8 s01007EF00011E000The Legend of Zelda Breath of the Wild
01007EF00011E000: REGRESSION