Skip to content

fix(chore): test-cleanup - #157

Merged
shossain786 merged 3 commits into
seleniumboot:masterfrom
PUSHPAK-JAISWAL:fix/test-cleanup
Oct 17, 2026
Merged

shossain786 merged 3 commits into
seleniumboot:masterfrom
PUSHPAK-JAISWAL:fix/test-cleanup

Conversation

@PUSHPAK-JAISWAL

@PUSHPAK-JAISWAL PUSHPAK-JAISWAL commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

What & why

Cleans up compiler warnings emitted during GitHub Actions CI builds (#155):

  1. CucumberStepLogger: Migrates off the deprecated PickleStepTestStep.getStepText() API in Cucumber 8.x to step.getStep().getText().
  2. BaseCucumberTest: Adds @Deprecated(since = "3.9.0") along with @SuppressWarnings({"deprecation", "removal"}) to silence upstream AbstractTestNGCucumberTests compiler warnings. Keeps full backwards compatibility with zero breaking changes for existing TestNG Cucumber users.
  3. pom.xml: Adds io.cucumber:cucumber-junit-platform-engine:8.0.3 as an <optional>true</optional> dependency to prepare the path for JUnit Platform Cucumber engine adoption.
  4. Test coverage: Adds unit tests for CucumberStepLogger verifying step text capture and status mapping.

Part One of #155

Type of change

  • Bug fix
  • New feature (opt-in, aligned with the framework philosophy)
  • Documentation
  • Internal refactor / test coverage

Checklist

  • All existing tests pass (mvn clean verify)
  • New behaviour is covered by unit tests
  • No new external dependencies introduced without prior discussion
  • Code follows existing conventions (no new frameworks, minimal abstraction)
  • No breaking changes to @SeleniumBootApi public APIs (or a major version bump is justified below)
  • Docs updated if user-facing behaviour changed (docs-site/)

Notes for reviewers

This is PR 1 of the two-phase approach agreed with @shossain786 in #155:

  • PR 1 (this PR): Warning cleanup only, no runtime behavior changes, zero breaking changes.
  • PR 2 (follow-up): JUnit Platform Cucumber suite execution, quarantine hook handling for JUnit, and listener parity.

PUSHPAK-JAISWAL and others added 3 commits October 16, 2026 11:04
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@shossain786
shossain786 merged commit e86e08c into seleniumboot:master Oct 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants