Skip to content

[UIK-5667][skeleton, spin-container, spin] redesign - #3106

Open
ilyabrower wants to merge 29 commits into
UIK-5351/add-more-variables-to-themefrom
UIK-5667/spin-redesign
Open

[UIK-5667][skeleton, spin-container, spin] redesign#3106
ilyabrower wants to merge 29 commits into
UIK-5351/add-more-variables-to-themefrom
UIK-5667/spin-redesign

Conversation

@ilyabrower

Copy link
Copy Markdown
Contributor

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

Comment thread semcore/spin/src/Spin.tsx
Comment thread semcore/spin/src/style/spin.shadow.css
Comment thread semcore/spin/src/Spin.type.ts Outdated
/**
* Flag for render the Spin in the dark theme.
*/
invert?: boolean;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed to not add a boolean prop, keep theme
can we deprecate the "dark" value somehow? ("default" should be used instead)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Valeria-Zimnitskaya
Valeria-Zimnitskaya self-requested a review August 12, 2026 16:53
@ilyabrower
ilyabrower force-pushed the UIK-5667/spin-redesign branch from c7048f9 to 0bffdc4 Compare August 14, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants