Repository navigation
Clean up now that the theme is public - #17
Merged
Merged
Conversation
Sites can fetch the theme without credentials now. Remove the Octo STS trust policy, which nothing reads anymore (the public octo-sts App is no longer installed on the org), and the README section that walked a consuming site through minting a token. The README's example pins move from v1.1.0 to v1.3.0, the version on main.
The README listed a CI/CD pipeline with automated testing and deployment, and automatic versioning and releases. CI here builds the demo site and nothing more, and versions are bumped by hand in the PR that ships them. The demo About page sent readers to the upstream README, whose setup steps are for smirnoffmg's theme rather than this one.
It came over from upstream as a guide for AI agents, and nearly every concrete rule in it is wrong for this repository: release.yml and pages.yml workflows that don't exist, a develop branch, Ruby 3.2, remote_theme pointing at smirnoffmg's repo, and "no JavaScript" next to a print button that calls window.print(). An agent following it would be misled, and nothing references the file.
Credit smirnoffmg/harvard-style-cv-theme by Maksim Smirnov right under the intro rather than only at the bottom. The Attribution section's list of what this fork adds stopped at 1.1.0; it now covers the print layout work, the print button and the Calendly link, and points at the CHANGELOG.
The demo About page ended with "Created by Maksim Smirnov". Credit for the original theme lives in the README (under the intro and in Attribution) and in LICENSE, so the demo page doesn't need its own line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo is public now, so a site can pull the theme with no credentials at all. This removes what was only there for the private days, plus a few docs that were wrong for this repo.
.github/chainguard/alex-cv-pages.sts.yaml. It was a trust policy for the public Octo STS App, which is no longer installed on the org, so nothing reads it. The one site that used it (alex-cv) stops minting a token in its own PR.CONSTITUTION.md, the AI-agent guide inherited from upstream. Almost every concrete rule in it is wrong here (workflows that don't exist, adevelopbranch, Ruby 3.2, "no JavaScript" next to the print button). It's a separate commit, so it's easy to leave out.No theme files change, so there's no version bump, and the gem still packs the same file list.
v1.3.0isn't tagged yet, though VERSION and the CHANGELOG on main already say 1.3.0. The README pins assume the tag lands with the #16 rollout.Checked by building the demo site (
--config _config.demo.yml) and runninggem buildin a clean ruby:3.4.9 container. The About page now renders the new link.