Skip to content

Gem forces the use of q parameter for engines that is not used #10

Description

@hartator

We have several engines that work without a q parameter.

For example, Yande uses text:

image

And you can't submit your search to the API.

Hash with all engines that don't use q parameter:

{
  ebay: '_nkw',
  google_maps_reviews: 'data_id',
  google_product: 'product_id',
  google_scholar_author: 'author_id',
  google_scholar_profiles: 'mauthors',
  home_depot_product: 'product_id',
  walmart: 'query',
  walmart_product: 'product_id',
  yahoo: 'p',
  yandex: 'text',
  youtube: 'search_query',
  naver: 'query',
  apple_app_store: 'term',
  apple_reviews: 'product_id',
  yahoo_shopping: 'p',
  google_play_product: 'product_id',
}

We can explicitly check on this but I think it will easier to just drop the requirement of a q parameter for all engines.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions