Skip to content

Docker build check along with PR Quality Checker #56

Closed
Closed
Docker build check along with PR Quality Checker#56
Assignees
torridfish

Description

@torridfish
torridfish
opened on May 30, 2026

Goal

Fail PRs that break the Docker image build before they reach main, so the CD pipeline (.github/workflows/cd.yml) never ships a broken release to GHCR.

Activity

  1. torridfish
    self-assigned this
    on May 30, 2026

  2. torridfish commented on Jul 19, 2026

    @torridfish
    torridfish
    on Jul 19, 2026
    MemberAuthor

    Resolved by PR #63, which adds .github/workflows/docker-build.yml. On any PR touching Dockerfile, docker-compose.yml, pyproject.toml, uv.lock, scripts/download_unidic.sh, or the workflow itself, it builds the image (no push) and runs an offline smoke test (--network none) confirming the baked dictionaries resolve. A broken Dockerfile, a stale uv.lock, or a failed dict bake fails the PR before merge. Closes when #63 merges.

  3. torridfish commented on Sep 14, 2026

    @torridfish
    torridfish
    on Sep 14, 2026
    MemberAuthor

    Closing: #63 merged as 1788d07, and the implementation is verified present on main.

    See the resolution comment above for the per-issue detail.

  4. torridfish
    closed this as completedon Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions