Repository navigation
Conversation
The JRuby test jobs took up to 25 minutes, starting a JVM for each of the many Ruby processes the tests run, and finished long after the rest. They're listed first in each matrix now, so they start before the others, and run with JRUBY_OPTS=--dev, which starts each process faster. Each test job also has a timeout, so a hang fails in minutes instead of running for six hours.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JRuby test jobs take 16 to 25 minutes, against 2 for CRuby, because the tests start a lot of Ruby processes and each one starts a JVM. This lists the JRuby (and TruffleRuby) entries first in every matrix that has them, so they get runners before the quick jobs, and runs JRuby with
JRUBY_OPTS=--dev, which trades peak JIT performance for faster startup. Nothing in these tests measures JRuby's performance, so that's a good trade. Each test job also gets a timeout (45 minutes for the main suite, 20 for the plugins), so a hang fails quickly instead of running for GitHub's six hours.