Repository navigation
Test on truffleruby-head, without failing the run - #80
Merged
Merged
Conversation
TruffleRuby is still experimental and rarely run in production, and its JVM build has crashed with a SIGSEGV on exit after every test passed, which failed the whole run and turned the badge red. Test on truffleruby-head instead of the released TruffleRuby builds, so it falls under continue-on-error like the other -head Rubies.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Duel: nothing to compare |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TruffleRuby+GraalVM job in https://github.com/sferik/multi_xml/actions/runs/40255326659 ran all 877 tests with no failures, then the JVM crashed with a SIGSEGV on exit, which failed the run and turned the badge red. That's a TruffleRuby bug, not ours.
TruffleRuby is still pretty experimental and not widely used in production, so this tests on
truffleruby-headinstead of the releasedtrufflerubyandtruffleruby+graalvm. The workflow already setscontinue-on-errorfor every-headRuby, so a TruffleRuby failure shows up on the job without failing the run, and without cancelling the rest of the matrix.truffleruby-headis the native build, so the JVM build isn't tested at all now, even though the README still lists TruffleRuby 33.0 (native and JVM).