Repository navigation
Update Duel to 0.1.1 - #81
Merged
Merged
Conversation
The Perf workflow now comments on a pull request only when Duel fails, as c.comment says by default, and posts a new comment instead of editing the last one. Duel 0.1.1 watches the benchmarks and .duel.rb itself, so .duel.rb only adds the workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the Duel setup to Duel 0.1.1.
The bot was commenting on every pull request, which was mostly noise, and it kept editing the same comment, so the history of earlier reports got lost. Now the Perf workflow only comments when Duel fails (that's the new default, and
c.commentin.duel.rbcan change it), and it always posts a new comment instead of editing the old one. If a later push fixes the regression, it posts once more to say so. The report itself is also much shorter, with just the failures in view and everything else collapsed.Duel 0.1.1 watches the benchmarks and
.duel.rbon its own now, so.duel.rbonly adds the workflow file, and the Gemfile requires 0.1.1 or later, since the workflow reads outputs that older versions don't write.