Repository navigation
chore(deps): migrate to SvelteKit 3 and bump undici for audit - #1028
Merged
Merged
Conversation
npm audit fails on master: undici 8.0.0-8.12.1 (high, via jsdom) and @sveltejs/kit < 3.0.0 (low, patched only in 3.0.0). - @sveltejs/kit 3.1.0, adapter-static 4.0.0, vite-plugin-svelte 7.3.1, vite 8.3.5, typescript 6.0.3, svelte 5.57.2 (Kit 3 minimums) - undici 8.12.3 in the lockfile (within jsdom's range) - svelte.config.js removed, its options move to the sveltekit() plugin - $lib imports become #lib, declared in package.json "imports" - tsconfig extends $app/tsconfig and declares its own include - drop the cookie 0.7.2 override, Kit 3 needs cookie 2 - editorOptionWiring test: TypeScript 6 emits "use strict" first, so the evaluated literal is bound to a name instead of returned as an expression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
npm auditfails on master since a1477cf's run:undici: ^8.9.0.undici moves to 8.12.3 in the lockfile, inside jsdom's range, so no override is needed. The Kit advisories need the major.
What changed
Versions, each to the minimum Kit 3 requires per the migration guide:
cookie: 0.7.2override is dropped. It only existed for Kit 2's cookie dependency, and Kit 3 importsparseCookiefrom cookie 2, so the override broke the build.Migration edits:
svelte.config.jsis no longer supported. Itsadapter(static,fallback: "index.html") andpreprocessmove into thesveltekit()plugin options invite.config.js.$libis no longer generated. The three$lib/...imports become#lib/..., declared inpackage.json"imports". The startup-graph test that resolves those specifiers follows.tsconfig.jsonextends$app/tsconfiginstead of./.svelte-kit/tsconfig.json, which declares noinclude, so the hand-copied list becomes["src", "scripts", "*"].transpileModuleoutput with"use strict", soreturn ${js}ineditorOptionWiring.test.tsreturned that string. The evaluated literal is now bound to a name and returned after.No change needed for Node: Kit 3 needs 22.17, CI runs 24.
ssr = falsein+layout.ts,$app/*(none used) and vitest config are unaffected.Verification
npm ciclean,npm audit0 vulnerabilities,npm run check0 errors,npm test1164 pass,npm run test:vitest560 pass,npm run buildsucceeds.build/matches master's layout:index.htmlSPA fallback with the same/_app/immutable/...paths, same Monaco workers, IME patch present. A macOS Tauri release.appbuilds.