Repository navigation
fix(editor): re-apply Sticky Headings to an open editor - #1031
Merged
Merged
Conversation
stickyScroll was set only in the monaco.editor.create() literal, so toggling the setting did nothing until the next editor was created. It now comes from editorOptionsFromSettings, which the updateOptions effect re-applies.
PathGao
force-pushed
the
fix-sticky-scroll-live
branch
from
October 26, 2026 07:03
80a162c to
f42fcbe
Compare
PathGao
added a commit
that referenced
this pull request
Oct 26, 2026
Sticky Headings now comes from editorOptionsFromSettings only, so the moved creation options no longer set it a second time, and the 'option a setting can change' test covers it instead of skipping it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toggling Sticky Headings in Settings did nothing to an editor that was already open; it only took effect for the next one.
stickyScrollwas set in themonaco.editor.create()literal only, so theupdateOptionseffect never re-applied it. It now comes fromeditorOptionsFromSettings, which both call sites share.Verified: the new test in editor.test.ts fails with the option moved back out of
editorOptionsFromSettingsand passes with it; full node/vitest suites and svelte-check green. Not yet clicked through in a built app.