fix(data): supervise historical Qwen thinking turns - #933
Open
cheater6666 wants to merge 1 commit into
Open
cheater6666 wants to merge 1 commit into
cheater6666 wants to merge 1 commit into
Conversation
cheater6666
requested review from
FrankLeeeee,
shuaills,
sleepcoo and
zyksir
as code owners
October 6, 2026 04:40
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Qwen3.5 and Qwen3-Next-Thinking render historical assistant turns without the
<think>scaffold used by the final assistant turn. The parser only matched the longer configured header, silently masking all historical assistant outputs from training.Modifications
Related Issues
Fixes #912
Accuracy Test
Input IDs are unchanged. All changed loss-mask values are
0 -> 1in historical assistant spans.Result: 3 tests passed.
Benchmark & Profiling
Not applicable; this changes preprocessing correctness, not runtime inference performance.
Checklist