Convert recursive DFS to iterative stack-based implementation - #29
Merged
Conversation
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the DFS function in the max flow algorithm from a recursive implementation to an iterative stack-based approach. This change improves robustness by eliminating potential stack overflow issues on deep graphs while maintaining the same algorithmic correctness.
Key Changes
dfs(v, up)function with an iterative version using an explicit stack data structuredfs(v, up)todfs(s_, t_, up)to accept both source and target nodes, enabling the iterative approachpathlist to track(node, edge_index)pairs during traversal, allowing capacity updates to be applied after finding an augmenting pathIter[v]increment managementImplementation Details
(node, flow_into_node)tuples representing the current traversal statelevel[v] = self.n) is preserved to maintain the algorithm's efficiency propertieshttps://claude.ai/code/session_01JAwRWVg1ZbRWobeGyFuc6a