Repository navigation
fix: ルーム名と背景の文字数をAPIとそろえる - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
「𠮷」を含むルーム名・背景が、上限の半分で切られる不具合を修正します。ルーム名120文字、背景4,000文字を画面とAPIで同じように扱います。
#19 の境界調査で、辞書の同じ問題は #35 で修正済みです。このPRは残る3入力へ対応し、背景の検査を共通化します。辞書の改版・永続化、認識Adapter、AI取消、手修正の保護、公開可否は既存の担当層に残します。参照元と残す理由は ARCHITECTURE.md に記録しています。
Closes #19
Evidence
After:
bash scripts/check.sh成功。Node 22.23.4、frontend 145件・backend 196件、型検査0エラー。生成契約も一致します。ローカルのfrontend件数には別作業の未コミットテスト1件を含み、このPRには含めていません。検証記録
Merge Danger
Door: two-way
既存データの変換やAPI形式の変更はありません。必要ならこのコミットをrevertできます。Pydanticの検証は保持します。
Blast Radius: forms
対象はルーム登録・編集とAI背景設定です。OS別認識や外部サービスへの実接続は今回の検証対象外です。
投稿セッション:合成音声でGemini・GPT動作確認